ci: check for version placeholders #2236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
force-pushed
the
checkForVersionPlaceholders
branch
7 times, most recently
from
7b7fc74 to
5c30541
Compare
individual-it
commented
Jan 29, 2026
individual-it
force-pushed
the
checkForVersionPlaceholders
branch
from
5c30541 to
4a83b34
Compare
saw-jan
approved these changes
Jan 29, 2026
dragonchaser
approved these changes
Jan 29, 2026
Contributor
|
@dragonchaser @individual-it I don't understand the current discussion. Maybe i missed something. Wasn't it the idea to use these placeholders because we do not know the next version string ATM? The replacement check should be done closely before the release, when we already know the next version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check for placeholders
%%NEXT%%and%%NEXT_PRODUCTION_VERSION%%and fail CI if there are still in the codeRelated Issue
part of #1933 (comment)
Motivation and Context
make sure the placeholders are replaced with correct versions before the release
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist: